-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support bytes array argument in solidity and vyper contracts #2255
fix: support bytes array argument in solidity and vyper contracts #2255
Conversation
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lemme know if you need help with failing tests - those should probably be less affected by changes if you want to genericize them more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a tuple of nits but looks good
(joke by @bitwise-constructs )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What I did
Added support for bytes array argument in solidity and vyper contracts
How I did it
Added a value converter for a list of hex values to a single concatenated hex value
How to verify it
tx = contract_instance.functionWithCalldata(["0x123456", "0xabcd"], sender=owner)
for
functionWithCalldata(bytes calldata data)
Checklist